Delete redundant caches for EmptyHttpResult #63485
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkotas
requested review from
BrennanConroy,
captainsafia and
halter73
as code owners
github-actions
bot
added
the
area-networking
There was a problem hiding this comment.
Pull Request Overview
This PR eliminates redundant caching of the EmptyHttpResult singleton by converting properties from cached getters to direct property accessors. The changes ensure that the singleton pattern is respected without creating unnecessary intermediate cached instances.
- Converts
TypedResults.Emptyfrom a cached property to a direct property accessor - Converts
Results.Emptyfrom delegating toTypedResults.Emptyto directly accessing the singleton instance
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Http/Http.Results/src/TypedResults.cs | Changed Empty property from cached getter to direct property accessor |
| src/Http/Http.Results/src/Results.cs | Changed Empty property to directly access EmptyHttpResult.Instance instead of TypedResults.Empty |
dotnet-policy-service
bot
added
the
pending-ci-rerun
davidfowl
approved these changes
Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delete redundant caches for EmptyHttpResult. This has secondary effect of allowing ResultExtensions to be trimmed when it is not used since it is not going to share the static constructor with EmptyHttpResult.